Commit Briefs
portable: release 0.96 (tags/0.96)
never write accum_buf on error in got_pack_dump_delta_chain_to_file()
and also avoid to override `err' if fwrite fails. ok millert, stsp
fix use of uninitialized variable in update_blob
spotted by smatch. ok millert@
plug memory leak in got_pack_dump_delta_chain_to_file()
found by smatch. ok stsp@
pass the argument to calloc in the right order; no-op in practice
reported by smatch.
fix logging during gotwebd shutdown
During `rcctl stop gotwebd' the sockets process gets a SIGTERM and dies, and this makes the parent process assume it exited abnormally. Instead, catch SIGINT and SIGTERM and exit gracefully. Issue reported by xs on IRC. ok jamsek
gotwebd: fix colour of target lines in dark mode
reported by xs on IRC, thanks!
Test log -b <path> traversing a merge commit.
This tests for the bug fixed by c8255edc. ok stsp@
handle merge commits that are unrelated to requested changed path history
Problem found and fix tested by James Cook.
portable: CI: update FreeBSD image
Bump the FreeBSD image used on Cirrus-CI to FreeBSD-13-2
plug some fd leaks in the fdopen{,dir} error paths
There's also a memory leak fixed. ok stsp@
style: no-op change in practice
change so it matches the style used in the rest of the tree. ok stsp
remove unneded wbuf->fd = -1
There's no need to set the fd to -1 on ibufs created with imsg_create(3), and it was probably never needed.
convert to use imsg_get_fd()
While here also fix a fd leak in got-read-pack. We were dup'ing imsg.fd without closing imsg.fd later; instead just use imsg_get_fd() to extract the file descriptor. Tested by falsifian and Kyle Ackerman, thanks! 'go ahead' stsp@
gotwebd: try to improve copy-paste from BLOB pages
This moves the space inside the line anchor and makes it non-selectable, so that when copy-pasting, only the content of line lines is actually copied. At the moment, this seems to behave slightly incorrectly in firefox which inserts a double line break due to the presence of unselectable elements inside the selection. Hopefully it will be fixed, chromium behaves fine. It also still works decently on text-browsers. ok stsp@
allow remotes without urls in git config in gotd
This is b624328edd but for the code used by gotd. ok stsp@
allow remotes without urls in git config
Also, add tests. This change lets got and related tools work when the git config file has "remote" sections without urls, like this one in one of my git-annex git repositories: [remote "h0-rsync"] annex-rsyncurl = (some url) annex-uuid = (some uuid) skipFetchAll = true Running tog and many got commands there would previously result in: $ tog got-read-gitconfig: gitconfig syntax error tog: gitconfig syntax error The change to got-read-gitconfig.c is by stsp@, with ok from op@ (and now me). Tests ok stsp@.
got.1: use typewriter-style quoting in got.conf author example
Otherwise copy/pasting from the man page to got.conf produces syntax errors. Noticed by mlarkin@