Commit Briefs

7cec82d8d4 Stefan Sperling

CHANGES for 0.96 (tags/0.96)


1bda45afb1 Omar Polo

never write accum_buf on error in got_pack_dump_delta_chain_to_file()

and also avoid to override `err' if fwrite fails. ok millert, stsp


8c8d22ba3f Omar Polo

fix use of uninitialized variable in update_blob

spotted by smatch. ok millert@


e9a3af3077 Omar Polo

plug memory leak in got_pack_dump_delta_chain_to_file()

found by smatch. ok stsp@


06bd8ee415 Omar Polo

fmt


db315d31c8 Omar Polo

pass the argument to calloc in the right order; no-op in practice

reported by smatch.


736fac9082 Omar Polo

fix logging during gotwebd shutdown

During `rcctl stop gotwebd' the sockets process gets a SIGTERM and dies, and this makes the parent process assume it exited abnormally. Instead, catch SIGINT and SIGTERM and exit gracefully. Issue reported by xs on IRC. ok jamsek


2fbb00a429 Omar Polo

gotwebd: fix colour of target lines in dark mode

reported by xs on IRC, thanks!


f9a64b1469 James Cook

Test log -b <path> traversing a merge commit.

This tests for the bug fixed by c8255edc. ok stsp@


c8255edc87 Stefan Sperling

handle merge commits that are unrelated to requested changed path history

Problem found and fix tested by James Cook.


fc9b745fd3 Omar Polo

plug some fd leaks in the fdopen{,dir} error paths

There's also a memory leak fixed. ok stsp@


b3be78f908 Omar Polo

style: no-op change in practice

change so it matches the style used in the rest of the tree. ok stsp


7614e0f6e8 Omar Polo

remove stray abort() call; ok stsp


bbca1adf04 Omar Polo

remove unneded wbuf->fd = -1

There's no need to set the fd to -1 on ibufs created with imsg_create(3), and it was probably never needed.


2c52c623be Omar Polo

convert to use imsg_get_fd()

While here also fix a fd leak in got-read-pack. We were dup'ing imsg.fd without closing imsg.fd later; instead just use imsg_get_fd() to extract the file descriptor. Tested by falsifian and Kyle Ackerman, thanks! 'go ahead' stsp@


50b6e2b853 Omar Polo

gotwebd: try to improve copy-paste from BLOB pages

This moves the space inside the line anchor and makes it non-selectable, so that when copy-pasting, only the content of line lines is actually copied. At the moment, this seems to behave slightly incorrectly in firefox which inserts a double line break due to the presence of unselectable elements inside the selection. Hopefully it will be fixed, chromium behaves fine. It also still works decently on text-browsers. ok stsp@


26b163a03e Omar Polo

gotwebd: guard against missig folder and file parameter in BLOB and BLAME

ok stsp


d4fbd6eb2c Omar Polo

allow remotes without urls in git config in gotd

This is b624328edd but for the code used by gotd. ok stsp@


b624328edd James Cook

allow remotes without urls in git config

Also, add tests. This change lets got and related tools work when the git config file has "remote" sections without urls, like this one in one of my git-annex git repositories: [remote "h0-rsync"] annex-rsyncurl = (some url) annex-uuid = (some uuid) skipFetchAll = true Running tog and many got commands there would previously result in: $ tog got-read-gitconfig: gitconfig syntax error tog: gitconfig syntax error The change to got-read-gitconfig.c is by stsp@, with ok from op@ (and now me). Tests ok stsp@.



d0980f09b2 Stefan Sperling

got.1: use typewriter-style quoting in got.conf author example

Otherwise copy/pasting from the man page to got.conf produces syntax errors. Noticed by mlarkin@


cfcfb026c8 Omar Polo

got-read-patch: use imsg_get_fd(), move FILE handling in main

also improves the error message in case of no fd was passed. ok stsp@


510b455540 Stefan Sperling

avoid opening objects in the gotd session process for no reason

The session process opened an object as part of a sanity check and simply closed it again. Opening an object involves decompression and combination of deltas. Add a new interface which checks whether an object ID exists without such overhead and call it from gotd.


722e143e83 Omar Polo

gotwebd.8: improve EXAMPLES sections

tweaks and ok stsp


e114f3d1c1 Omar Polo

gotwebd: retire max_repos setting

Unlike max_repos_display which limits the number of items per page, max_repos is an hard-limit on the number of repos gotwebd would process. "kill it with fire" tracey@ about the idea ok stsp