commit 740feb0c47c85a20acac2ed8a812efc6f3ee3e21
from: Stefan Sperling <stsp@stsp.name>
date: Thu Sep 07 10:39:37 2023 UTC

back out "fix bogus pointer being passed to fill_tmpfile() for T_HANDLER_FILL1"

This backs out commit 1bb61b1da84f5690f3125d4f6595b833632622b4:

The commit broke configuration file syntax checks. It triggeed errors
from exec since we were trying to exec a list of garbage arguments.
I misunderstood what the fillargs[1] pointer represents. Even though it
is a char * the value stored in case of FILLARGS1 is in fact a char *[].

commit - b89991056cdba3650e3f4782b0a938b3c38116f9
commit + 740feb0c47c85a20acac2ed8a812efc6f3ee3e21
blob - 407a33805d855e38bbb8d2106b5ae650ca1bf46b
blob + 4011e0f3cb3a14e6359f82f82497db29b47dcd89
--- ctl.c
+++ ctl.c
@@ -672,7 +672,7 @@ ctlhandler(int argc, char **argv, char *modhvar)
 	break;
 	case T_HANDLER_FILL1:
 		/* pointer to handler routine, fill args @ args[1] pointer */
-		if (fill_tmpfile((char **)&fillargs[1], tmpfile, tmp_args))
+		if (fill_tmpfile((char **)fillargs[1], tmpfile, tmp_args))
 			(*x->handler)(fillargs[0], tmp_args, fillargs[2]);
 		else
 			(*x->handler)(fillargs[0], (char **)fillargs[1], fillargs[2]);