commit 52d9b7b44f0ba4d1d3dffad87cff38f67b74ec83
from: Jelmer Vernooij <jelmer@jelmer.uk>
date: Fri Jan 13 18:31:36 2023 UTC

Avoid refetching deltas.

commit - a804738d890f0e63618119bc92f257cd3644a2f5
commit + 52d9b7b44f0ba4d1d3dffad87cff38f67b74ec83
blob - 51f92d8a4371fe11142b4c2932f48eeca079080c
blob + 37514791e08bab20fa7361bd80c5e669b39fdc0c
--- dulwich/pack.py
+++ dulwich/pack.py
@@ -1666,12 +1666,15 @@ def deltify_pack_objects(objects, window_size=None, re
         for obj, path in objects:
             objects_to_pack.add(sha_to_hex(obj.sha().digest()))
         for o, _ in objects:
-            if not o.sha().digest() in reuse_pack:
-                continue
+            sha_digest = o.sha().digest()
             # get_raw_unresolved() translates OFS_DELTA into REF_DELTA for us
-            (obj_type, delta_base, _) = reuse_pack.get_raw_unresolved(o.sha().digest())
+            try:
+                (obj_type, delta_base, chunks) = reuse_pack.get_raw_unresolved(sha_digest)
+            except KeyError:
+                continue
             if obj_type == REF_DELTA and delta_base in objects_to_pack:
-                reused_deltas.add(o.sha().digest())
+                yield obj_type, sha_digest, hex_to_sha(delta_base), chunks
+                reused_deltas.add(sha_digest)
 
     # Build a list of objects ordered by the magic Linus heuristic
     # This helps us find good objects to diff against us
@@ -1707,10 +1710,6 @@ def deltify_pack_objects(objects, window_size=None, re
         possible_bases.appendleft((o.sha().digest(), type_num, raw))
         while len(possible_bases) > window_size:
             possible_bases.pop()
-
-    for sha_digest in reused_deltas:
-        (obj_type, delta_base, chunks) = reuse_pack.get_raw_delta(sha_digest)
-        yield obj_type, sha_digest, hex_to_sha(delta_base), chunks
 
 
 def pack_objects_to_data(objects):
@@ -1757,7 +1756,8 @@ def write_pack_objects(
         # slow at the moment.
         deltify = False
     if deltify:
-        pack_contents = deltify_pack_objects(objects, delta_window_size, reuse_pack)
+        pack_contents = deltify_pack_objects(
+            objects, window_size=delta_window_size, reuse_pack=reuse_pack)
         pack_contents_count = len(objects)
     else:
         pack_contents_count, pack_contents = pack_objects_to_data(objects)