commit 34943005498051116f012630a765ec209195b8bc
from: Stefan Sperling <stsp@stsp.name>
via: Thomas Adam <thomas@xteddy.org>
date: Sun May 26 14:05:55 2024 UTC

remove a redundant bounds check which gets elided by clang

found by + ok op@

commit - e9f3a90fadf12ed91fd75810d2321941b4df8bbd
commit + 34943005498051116f012630a765ec209195b8bc
blob - 00299a0cc98e46c79771198f9712ef9e9baf581a
blob + 5664cfa55cbbbebf65e037617cfa3913feda7ec8
--- lib/pack_index.c
+++ lib/pack_index.c
@@ -242,12 +242,6 @@ read_packed_object(struct got_pack *pack, struct got_i
 		if (pack->map) {
 			if (mapoff + SHA1_DIGEST_LENGTH >= pack->filesize) {
 				err = got_error(GOT_ERR_BAD_PACKFILE);
-				break;
-			}
-			if (mapoff + SHA1_DIGEST_LENGTH > SIZE_MAX) {
-				err = got_error_fmt(GOT_ERR_RANGE,
-				    "mapoff %lld would overflow size_t",
-				    (long long)mapoff + SHA1_DIGEST_LENGTH);
 				break;
 			}
 			memcpy(obj->delta.ref.ref_id.sha1, pack->map + mapoff,