Commit Briefs
fix adding blackhole and reject routes; a gateway is required (route-iface)
Fixes an invalid route message error during nsh -i at boot time: % cmd: route (line 49) margv [route 224.0.0.0/4 127.0.0.1 iface nompath reject] % RTM_ADD: Add Route: len 128, table 0, pid: 0, seq 1, errno 0, flags:<UP,REJECT,STATIC> % locks: inits: % sockaddrs: <DST,NETMASK> 224.0.0.0 240.0.0.0 % ip_route: rtmsg: Invalid argument
silence ifconfig errors related to carp demotion at boot time
This happens when nsh is started by /etc/rc.d/nsh during boot. The /etc/rc script starts package scripts with carp-interlock already enabled, and both ifconfig and nsh would attempt to reset the carp demotion counter. Generally, this is harmless, apart from an error message displayed by ifconfig which might mislead users into assuming there was a problem: starting package daemons: nsh. ifconfig: carp: SIOCSIFGATTR: Invalid argument To avoid this issue, nsh can check whether the demotion counter has already been set to the desired level and only change the counter if changing it is indeed required. test + ok Tom
avoid use of uninitialized variable 'sin'
found by codechecker
call getprogname(3) instead of reading __progname which is reserved
found by codechecker
ifmedia words are 64 bit wide on openbsd
found by codechecker
handle SIGWINCH in a signal-safe way
The setwinsize() function calls an ioctl which is not async-signal-safe. Use a safe signal handler and change window size in command loop instead. found by codechecker
left-shift by 32 bits needs to use unsigned long long
found by codechecker
need to free vis on error in mbs2ws()
found by codechecker
plug file descriptor leak in who.c
found by codechecker
handle edge-case of zero no-commands in complete_nocmd(); should not happen
found by codechecker
must initialize ndp.c variable 'nbi' in case for-loop never runs
found by codechecker
in growwgdata, preserve original pointer during realloc for freeing on error
found by codechecker
preserve original pointer during realloc and free on error
found by codechecker
preserve original pointer during realloc() and free on error return
found by codechecker
Update README.md
Update with rendering from latest manual page
Merge pull request #154 from smytht/exclamation-mark-change
! without arguments should not fork a new shell
Update commands.c
fix typo in exit command in bridge commands struct