ok Tom

These commands were hard-coded to use rtable 0. Problem found by Tom.

test + ok Tom

Suggested by Tom

It is possible to get "no such process" (ESRCH) errors during flush arp or flush route commands due to concurrent deletion of routing table entries by another process. This is no reason to stop trying to delete more routes, so do not abort the loop in this case. Also, make nsh print a more informative error message in this case, rather than "no such process". Example of the new error message: % No such route to delete: 100.64.1.2 fe:e1:ba:d0:8e:45 255.255.255.255 fe:e1:bb:d1:c4:b8 100.64.1.3 Testing + OK Tom

Attempting this results in "invalid argument" errors from the kernel. testing + ok Tom

Fix flush pf commands and improve flush documentation OK STSP

nsh -i/-c wrote daemon config files in /var/run by opening the file in append-only mode, adding a single line, closing the file again, and running chmod on the file. All this over and over, for every line. This is inefficient and also results in the problem that the full file content gets re-appended to the file each time nsh -i is run. Instead, open the file once when a new rules section is encountered, and close it when a different file needs to be written or when we can tell that we have left a "rules" section. The last open file might end up being closed implicitly when nsh -i/-c exits. While nsh -i should only be run once at boot-time which renders this issue moot, nsh -c can be run often, and the issue will also trigger during manual testing of nsh -i which is quite irritating. testing + OK Tom

update flush test script to remove defunct commands and add new commands related to flush pf

Rules for rdomain-specific daemons have double-indentation in nshrc. When generating configuration files for daemons strip double-indentation instead of stripping only one level of indentation. testing + ok Tom

flush nat and flush queues dont work, added in new flush commands to match pfctl -F [modifier]

Resolves dozens of: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C2x In traditional C the empty argument list () indicates that a function accepts an arbitrary amount of arguments of arbitary types. A function which takes no arguments must be declared with a (void) prototype instead. nsh has been making elaborate use of this feature by defining command handlers with () and passing arbitrary arguments to handlers depending on the use case. This coding style is not future-proof. In C++, () means "no arguments", the same as (void), and clang is now warning about this C feature going away in C2x, aligning C with C++. Make nsh future-proof by using variadic function prototypes (...) instead of () prototypes. Every handler now uses (int argc, char **argv, ...) as prototype: the argument count, an argument vector, followed by arbitrary arguments which can be extracted using the va_arg(3) function from stdarg.h. The variadic part of the argument list can be used to pass arguments of types other than char * without needing to convert them to strings and back. Using () as function prototype defeats type-checking done by the compiler, and the same is true for variadic arguments. We still need to manually make sure that the correct amount and types of arguments are passed in the variadic part of the handler's argument list. Many handlers already use the argument count + argument vector approach and do not need internal changes, just a new prototype. Some handlers now require use of va_start/va_arg/va_end to access additional arguments. For example, the interfaces handlers were passing an interface name and file descriptor before the argument count/vector. The order of arguments is now swapped, such that interface name and file descriptor get passed as part of the variable argument list. Testing + OK Tom

added these basic test scripts to allow for testing nsh commands that dont alter configs

remove extra telnet command and edit telnet command so it fails saying connection refused

rename flush-commands-test to flush-test.nshrc

used to assist in testing nsh can be run interactively or called in a nsh -c command

implement a reload reboot command alias

Fixes warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x

resolves warning: unused function 'int_clear' [-Wunused-function]

reload is a common command used to restart routers / switches added a reload alisas and updated the manual to improve the help for the reboot command reload is added to the list that does not get listed in help / ambiguous checks trivial Change ...