This happens when nsh is started by /etc/rc.d/nsh during boot. The /etc/rc script starts package scripts with carp-interlock already enabled, and both ifconfig and nsh would attempt to reset the carp demotion counter. Generally, this is harmless, apart from an error message displayed by ifconfig which might mislead users into assuming there was a problem: starting package daemons: nsh. ifconfig: carp: SIOCSIFGATTR: Invalid argument To avoid this issue, nsh can check whether the demotion counter has already been set to the desired level and only change the counter if changing it is indeed required.

found by codechecker

found by codechecker

found by codechecker

The setwinsize() function calls an ioctl which is not async-signal-safe. Use a safe signal handler and change window size in command loop instead. found by codechecker

found by codechecker

found by codechecker

found by codechecker

found by codechecker

found by codechecker

found by codechecker

found by codechecker

found by codechecker

Update with rendering from latest manual page

ok Tom

! without arguments should not fork a new shell

fix typo in exit command in bridge commands struct

This is the intended change from commit cfd60254

This Diff changes the behaviour of nsh interactively by checking if ! has been entered without any arguments, if the user is in global config mode or privileged mode the user is returned to the same prompt. if the user is in interface config mode or bridge config mode the user is returned to the global configuration mode This is to facilitate users copying and pasting nshrc configuration from one device to another interactively.

Unintended changes were mixed into this commit; discussed with Tom

fix conf_patch to avoid overwriting the current interface being shown I have reviewed the Code what stsp describes makes sense and the diff works and appears to solves the issue raised by ryan-sg OK Tom

fix typo in bridge commands struct (missing) field for exit command